Skip to content
Snippets Groups Projects
Commit fc9006b1 authored by Christian Meyer's avatar Christian Meyer
Browse files

CategoryCollector.java: separator can only be changed in subclasses

parent aeda4e2b
No related branches found
No related tags found
No related merge requests found
......@@ -35,15 +35,15 @@ public abstract class CategoryCollector<K, V extends Collectable<U>, U>
@SuppressWarnings("unused")
private static final Logger logger = Logger.getLogger(CategoryCollector.class.getName());
private static final long serialVersionUID = 1L;
/**
* Separator in headers between category prefix and collectable's header.
*/
private static final String SEPARATOR = "$";
private final Map<K, V> collectablePerCategory;
/** Accumulated size of all collectables. */
private final int totalSize;
/**
* Separator in headers between category prefix and collectable's header.
*/
private String separator = "$";
private Collectable<U> mergingCollectable = new MergingCollectable();
private final Collectable<U> mergingCollectable = new MergingCollectable();
/**
* Constructs a new {@code DefinitionSeparatedCollector}. Each given
......@@ -92,6 +92,16 @@ public abstract class CategoryCollector<K, V extends Collectable<U>, U>
return category.toString();
}
/**
* Separator in headers between category prefix and collectable's header.
* The default is '$'. Subclasses can provide a different one.
*
* @return the separator
*/
protected String getSeparator() {
return SEPARATOR;
}
/**
*
* @param category
......@@ -100,16 +110,6 @@ public abstract class CategoryCollector<K, V extends Collectable<U>, U>
*/
protected abstract V createCollectable(K category);
/**
* Sets the separator string in headers between category prefix and
* collectable's header.
*
* @param separator
*/
public void setSeparator(String separator) {
this.separator = separator;
}
@Override
public void beforeCollect(BeforeMessage message) {
}
......@@ -153,7 +153,7 @@ public abstract class CategoryCollector<K, V extends Collectable<U>, U>
Collection<String> headers = new ArrayList<>(totalSize);
for (K key : collectablePerCategory.keySet()) {
for (String header : collectablePerCategory.get(key).obtainHeaders()) {
headers.add(createCategoryHeaderPrefix(key) + separator + header);
headers.add(createCategoryHeaderPrefix(key) + getSeparator() + header);
}
}
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment